Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CSharpHelper for List literals #28212

Merged
2 commits merged into from
Jun 27, 2022
Merged

Add support for CSharpHelper for List literals #28212

2 commits merged into from
Jun 27, 2022

Conversation

yinzara
Copy link
Contributor

@yinzara yinzara commented Jun 13, 2022

Fixes #19274

Also relates to npgsql/efcore.pg#2402

  • [X ] I've read the guidelines for contributing and seen the walkthrough
  • [X ] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@dnfadmin
Copy link

dnfadmin commented Jun 13, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@yinzara yinzara force-pushed the feature/19274 branch 2 times, most recently from 040ef66 to cbb0bd7 Compare June 13, 2022 17:36
@yinzara
Copy link
Contributor Author

yinzara commented Jun 13, 2022

All comments addressed. TY!

@roji
Copy link
Member

roji commented Jun 21, 2022

Note: waiting for @bricelam to make sure it aligns with his work etc.

@yinzara
Copy link
Contributor Author

yinzara commented Jun 27, 2022

All comments have been addressed. I think we're ok for merge.

@ghost
Copy link

ghost commented Jun 27, 2022

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f72888f into dotnet:main Jun 27, 2022
@ajcvickers ajcvickers mentioned this pull request Jul 7, 2022
Closed
@roji roji mentioned this pull request Jul 9, 2022
Open
@roji roji mentioned this pull request Aug 1, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@bricelam bricelam bricelam approved these changes

Assignees

@roji roji

Labels
auto-merge community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSharpHelper: support more types of collection literals
5 participants
@yinzara @dnfadmin @roji @bricelam @ajcvickers